Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-7498 #191

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

alessandrobenedetti
Copy link
Contributor

This Pull Request related to the JIRA issue : LUCENE-7498

It involves the introduction of a big refactor of the More Like This module and the introduction of the BM25 similarity.

It is not supposed to be a final patch but to put the basis for a big improvement in the More Like This code base.
Any feedback is welcome

Summary
MoreLikeThis becomes a facade, just to expose the main More Like This functionality.
Responsibility are now separated in :

  • Interesting Terms retriever ( from a docId in the index or from a Lucene Document passed in input)
  • Scorer ( to identify how much a term is interesting : BM25 and TFIDF supported
  • Mlt query builder ( to build the query from the interesting terms)

Every component is specifically tested.

The modification impact as a side effect :

Classification
Knn CLassifiers to use the refactored More Like This
Knn query in Lucene will be slightly different

Single Solr Instance
The refactored MLT usage by Solr

SolrCloud
The refactored MLT usage by SolrCloud

@ctargett ctargett changed the title Lucene-7498 LUCENE-7498 Jan 18, 2019
gautamworah96 added a commit to gautamworah96/lucene-solr that referenced this pull request Jul 2, 2021
epugh pushed a commit to epugh/lucene-solr-1 that referenced this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant